ci: add Windows unit-test job to catch OS-specific path bugs#1522
Open
dimitri-yatsenko wants to merge 1 commit into
Open
ci: add Windows unit-test job to catch OS-specific path bugs#1522dimitri-yatsenko wants to merge 1 commit into
dimitri-yatsenko wants to merge 1 commit into
Conversation
The CI matrix ran Linux-only, so platform-specific defects — e.g. #1520, where file-protocol paths rendered with native backslashes broke garbage collection on Windows — could not be caught. Add a windows-latest leg running the container-free unit suite across both ends of the supported Python range (3.10, 3.14). pixi targets linux/osx only ([tool.pixi] platforms), so this leg installs via pip (.[test]) rather than pixi. Unit tests need no containers, so no Docker/DB is required on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI matrix ran Linux-only, so OS-specific defects couldn't be caught. #1520 is the motivating case:
StorageBackend._full_path()rendered file-protocol paths with native backslashes on Windows, which broke garbage collection (every live file looked orphaned;collect()could delete referenced files). #1521 fixes it, but nothing in CI exercises Windows, so the regression — and its whole class — would recur silently.What
Adds a
unit-tests-windowsjob onwindows-latestrunning the container-free unit suite (tests/unit) across both ends of the supported Python range (3.10, 3.14).testjob needs Docker/Linux containers (testcontainers), which don't fit Windows runners. The unit suite needs no containers and is where the path-handling logic (incl. Bug: GarbageCollector deletes live files on Windows due to backslash/forward-slash path mismatch in file-protocol stores #1520) actually lives, so it's the right and sufficient surface for a Windows guard.[tool.pixi] platformshas nowin-64, and the lock isn't solved for it), so this leg usesactions/setup-python+pip install -e ".[test]". Thetestextra's deps all ship Windows wheels. The existing Linuxunit-tests(pixi) job is unchanged.fetch-depth: 0sohatch-vcscan derive the version on the editable install.Notes
test_storage_adapter.py::test_file_protocol_full_path_uses_forward_slashesfails. (As noted in the Use POSIX separators in file-protocol paths #1521 review, an end-to-end GC integration test on Windows would strengthen this further — this PR provides the runner; the deeper test can follow.)win-64is added to the pixi platforms and the lock re-solved.